Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Response limit tracker #6814

Conversation

Guitarheroua
Copy link
Contributor

Closes: #6640

NOTE: this PR should be merged after #6798

Implements rate limiter for responses, that controller returns to client.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 41.18%. Comparing base (47f24e9) to head (78192e0).

Files with missing lines Patch % Lines
engine/access/rest/websockets/controller.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6814      +/-   ##
==========================================
- Coverage   41.18%   41.18%   -0.01%     
==========================================
  Files        2109     2109              
  Lines      185660   185664       +4     
==========================================
  Hits        76467    76467              
- Misses     102782   102786       +4     
  Partials     6411     6411              
Flag Coverage Δ
unittests 41.18% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@illia-malachyn illia-malachyn changed the title [Access] Responce limit tracker [Access] Response limit tracker Dec 13, 2024
@Guitarheroua Guitarheroua self-assigned this Dec 17, 2024
@peterargue
Copy link
Contributor

@Guitarheroua please address merge conflicts

@Guitarheroua Guitarheroua marked this pull request as ready for review December 30, 2024 14:10
@illia-malachyn illia-malachyn self-requested a review January 2, 2025 10:43
@peterargue peterargue requested a review from durkmurder January 2, 2025 17:56
Copy link
Member

@durkmurder durkmurder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left a few comments tests related.

Co-authored-by: Yurii Oleksyshyn <[email protected]>
@Guitarheroua Guitarheroua added this pull request to the merge queue Jan 9, 2025
Merged via the queue into onflow:master with commit 98e7b14 Jan 9, 2025
56 checks passed
@Guitarheroua Guitarheroua deleted the AndriiSlisarchuk/6640-responce-limit-tracker branch January 9, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Implement response limit tracker routine for ws controller
5 participants